Open
Conversation
|
|
hellais
added a commit
to ooni/data
that referenced
this pull request
Apr 25, 2024
hellais
commented
Apr 25, 2024
|
|
||
| task_list = [] | ||
| async with asyncio.TaskGroup() as tg: | ||
| for key in record_uri_list: |
Author
There was a problem hiding this comment.
This is no good as it runs the risk of spamming the event history log. It should probably work similarly to the java example where it uses continue_as_new to reset the event history.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Add a batch_daily example that demonstrates how to process records divided into daily batches of records.
Why?
It was helpful to better understand how to implement my use-case in a toy project.
Checklist
Closes: Sample request: Batch #112
How was this tested:
Ran the steps outlined in the README.md for this subtree and confirmed it ran properly.